Skip to content

Implement parsing gen fn #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement parsing gen fn #272

wants to merge 2 commits into from

Conversation

narpfel
Copy link

@narpfel narpfel commented Apr 7, 2025

Generator functions were implemented in rust-lang/rust#118457, tracking issue rust-lang/rust#117078.

@wetneb
Copy link

wetneb commented Jun 4, 2025 •
edited
Loading

Hi @narpfel , I have noticed that PRs in this repository are infrequently reviewed, so I have integrated your PR in a fork of this grammar. If you use this grammar in Rust, you can benefit from the improvements in this PR by switching to the tree-sitter-rust-orchard crate on crates.io. Let me know if you need the grammar published in another package repository. I would very much welcome more contributions like this one in the fork, to which I would also be happy to give you write access.

Dear maintainers,
Thank you for your work. It is completely understandable that you have higher priorities in life than integrating external contributions in this repository. If you still wish those contributions to get reviewed, I encourage you to give maintainer rights to more people. The list of PRs and the commit log should help you identify trustworthy contributors who might be interested in helping out. Onboarding new contributors might also be easier if you adopt a governance model for this project. If there is any way I can help, let me know.

wetneb pushed a commit to wetneb/tree-sitter-rust that referenced this pull request Aug 1, 2025
@narpfel @wetneb
feat: Implement parsing gen fn (tree-sitter#3)
aa0441b 
Porting of the unreviewed PR tree-sitter#272

----

Generator functions were implemented in
rust-lang/rust#118457,
tracking issue rust-lang/rust#117078.

Co-authored-by: Paul Gey <[email protected]>
Reviewed-on: https://codeberg.org/grammar-orchard/tree-sitter-rust-orchard/pulls/3
@narpfel
Copy link
Author

narpfel commented Oct 8, 2025

Rebased onto current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxbrunsfeld maxbrunsfeld maxbrunsfeld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@narpfel @wetneb @maxbrunsfeld